Merged
Conversation
- Call `cast_as` in fully qualified syntax in `DeriveEntityModel`
Member
Author
|
I found a issue where |
Expurple
reviewed
May 24, 2025
Member
Expurple
left a comment
Expurple
left a comment
There was a problem hiding this comment.
Thank you. Everything looks good, but cargo test --workspace fails. You need to add two more imports.
After that, we can trigger a CI run to check other test configurations
1 task
Expurple
approved these changes
Jun 1, 2025
Member
Expurple
left a comment
Expurple
left a comment
There was a problem hiding this comment.
Everything seems good in both PRs, thank you.
Now we can:
- merge SeaQL/sea-query#890
- then rollback the
Cargo.tomlchanges here (should've kept the Draft status until then, so that we don't forget) - merge this PR
Member
|
SeaQL/sea-query#890 has been merged. Now we can rollback the |
1 task
Member
|
@tyt2y3, you can merge this now. The new CI failures come from SeaQL/sea-query#891 (#2607 not being merged yet) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Info
SimpleExprmethods that duplicateExprTraitsea-query#890New Features
Bug Fixes
Breaking Changes
Changes